Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: pkg/analyzer/lib/src/summary/format.dart

Issue 2428413003: Mark some other instances of visibleLength/visibleOffset as informative. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/idl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/format.dart
diff --git a/pkg/analyzer/lib/src/summary/format.dart b/pkg/analyzer/lib/src/summary/format.dart
index 6d4ecc85c6e9d8512be377331dc9ac3b251ed343..d24aa70ebeb135f55d9ab6f67784ff98ce6a3660 100644
--- a/pkg/analyzer/lib/src/summary/format.dart
+++ b/pkg/analyzer/lib/src/summary/format.dart
@@ -6970,6 +6970,8 @@ class UnlinkedParamBuilder extends Object with _UnlinkedParamMixin implements id
_nameOffset = null;
_parameters?.forEach((b) => b.flushInformative());
_type?.flushInformative();
+ _visibleLength = null;
+ _visibleOffset = null;
}
/**
@@ -6999,8 +7001,6 @@ class UnlinkedParamBuilder extends Object with _UnlinkedParamMixin implements id
x?.collectApiSignature(signature);
}
}
- signature.addInt(this._visibleLength ?? 0);
- signature.addInt(this._visibleOffset ?? 0);
signature.addBool(this._initializer != null);
this._initializer?.collectApiSignature(signature);
signature.addInt(this._inheritsCovariantSlot ?? 0);
@@ -9245,6 +9245,8 @@ class UnlinkedVariableBuilder extends Object with _UnlinkedVariableMixin impleme
_initializer?.flushInformative();
_nameOffset = null;
_type?.flushInformative();
+ _visibleLength = null;
+ _visibleOffset = null;
}
/**
@@ -9267,8 +9269,6 @@ class UnlinkedVariableBuilder extends Object with _UnlinkedVariableMixin impleme
}
}
signature.addInt(this._inferredTypeSlot ?? 0);
- signature.addInt(this._visibleLength ?? 0);
- signature.addInt(this._visibleOffset ?? 0);
signature.addBool(this._initializer != null);
this._initializer?.collectApiSignature(signature);
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/idl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698