Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc ('k') | chrome/browser/history/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index a49ca16f10f5a41f398051593335b7eda9612d9c..ba409d844dc8a4704c4622d2369bb46c1755e2f9 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -131,8 +131,8 @@ const BookmarkNode* BookmarksFunction::GetBookmarkNodeFromId(
if (!GetBookmarkIdAsInt64(id_string, &id))
return NULL;
- BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
- const BookmarkNode* node = model->GetNodeByID(id);
+ const BookmarkNode* node = GetBookmarkNodeByID(
+ BookmarkModelFactory::GetForProfile(GetProfile()), id);
if (!node)
error_ = keys::kNoNodeError;
@@ -523,7 +523,7 @@ bool BookmarksCreateFunction::RunImpl() {
if (!GetBookmarkIdAsInt64(*params->bookmark.parent_id, &parentId))
return false;
}
- const BookmarkNode* parent = model->GetNodeByID(parentId);
+ const BookmarkNode* parent = GetBookmarkNodeByID(model, parentId);
if (!parent) {
error_ = keys::kNoParentError;
return false;
@@ -611,7 +611,7 @@ bool BookmarksMoveFunction::RunImpl() {
if (!GetBookmarkIdAsInt64(*params->destination.parent_id, &parentId))
return false;
- parent = model->GetNodeByID(parentId);
+ parent = GetBookmarkNodeByID(model, parentId);
}
if (!parent) {
error_ = keys::kNoParentError;
@@ -739,7 +739,7 @@ class CreateBookmarkBucketMapper : public BookmarkBucketMapper<std::string> {
int64 parent_id_int64;
base::StringToInt64(parent_id, &parent_id_int64);
- const BookmarkNode* parent = model->GetNodeByID(parent_id_int64);
+ const BookmarkNode* parent = GetBookmarkNodeByID(model, parent_id_int64);
if (!parent)
return;
@@ -777,7 +777,7 @@ class RemoveBookmarksBucketMapper : public BookmarkBucketMapper<std::string> {
for (IdList::iterator it = ids.begin(); it != ids.end(); ++it) {
BookmarkModel* model = BookmarkModelFactory::GetForProfile(
Profile::FromBrowserContext(browser_context_));
- const BookmarkNode* node = model->GetNodeByID(*it);
+ const BookmarkNode* node = GetBookmarkNodeByID(model, *it);
if (!node || node->is_root())
return;
« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc ('k') | chrome/browser/history/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698