chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc - Issue 242823002: Extract GetNodeByID() method from BookmarkModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

index 47920e581e3f7eb4bff3e4e21006030484747c0d..58ff5873fe749a6e492b82ce87002549b5f28a89 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

@@ -10,6 +10,7 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

+#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h"

#include "chrome/common/extensions/api/bookmarks.h"

@@ -100,7 +101,7 @@ bool RemoveNode(BookmarkModel* model,

int64 id,

bool recursive,

std::string* error) {

- const BookmarkNode* node = model->GetNodeByID(id);

+ const BookmarkNode* node = GetBookmarkNodeByID(model, id);

if (!node) {

*error = keys::kNoNodeError;

return false;