Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5097)

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model.h
diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h
index 70ca10aa8bc690757f9006207985ccea9435bc64..bccad410d324063a38a9903272b29cae8e420abe 100644
--- a/chrome/browser/bookmarks/bookmark_model.h
+++ b/chrome/browser/bookmarks/bookmark_model.h
@@ -74,16 +74,16 @@ class BookmarkModel : public content::NotificationObserver,
// Returns the root node. The 'bookmark bar' node and 'other' node are
// children of the root node.
- const BookmarkNode* root_node() { return &root_; }
+ const BookmarkNode* root_node() const { return &root_; }
// Returns the 'bookmark bar' node. This is NULL until loaded.
- const BookmarkNode* bookmark_bar_node() { return bookmark_bar_node_; }
+ const BookmarkNode* bookmark_bar_node() const { return bookmark_bar_node_; }
// Returns the 'other' node. This is NULL until loaded.
- const BookmarkNode* other_node() { return other_node_; }
+ const BookmarkNode* other_node() const { return other_node_; }
// Returns the 'mobile' node. This is NULL until loaded.
- const BookmarkNode* mobile_node() { return mobile_node_; }
+ const BookmarkNode* mobile_node() const { return mobile_node_; }
bool is_root_node(const BookmarkNode* node) const { return node == &root_; }
@@ -173,9 +173,6 @@ class BookmarkModel : public content::NotificationObserver,
// See BookmarkService for more details on this.
virtual void BlockTillLoaded() OVERRIDE;
- // Returns the node with |id|, or NULL if there is no node with |id|.
- const BookmarkNode* GetNodeByID(int64 id) const;
-
// Adds a new folder node at the specified position.
const BookmarkNode* AddFolder(const BookmarkNode* parent,
int index,
@@ -306,9 +303,6 @@ class BookmarkModel : public content::NotificationObserver,
int index,
BookmarkNode* node);
- // Implementation of GetNodeByID.
- const BookmarkNode* GetNodeByID(const BookmarkNode* node, int64 id) const;
-
// Returns true if the parent and index are valid.
bool IsValidIndex(const BookmarkNode* parent, int index, bool allow_end);
« no previous file with comments | « chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc ('k') | chrome/browser/bookmarks/bookmark_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698