Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 242823002: Extract GetNodeByID() method from BookmarkModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert a change in bookmarks_helper.cc that colides with a wstring and cq does not like that Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_node_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model.cc
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc
index cdd91f5a973a1d0d8e0ba2b28e3f0da935a5f4b3..ec89a1716d43e7de9f71661b8d2be01edd813d43 100644
--- a/chrome/browser/bookmarks/bookmark_model.cc
+++ b/chrome/browser/bookmarks/bookmark_model.cc
@@ -493,11 +493,6 @@ void BookmarkModel::BlockTillLoaded() {
loaded_signal_.Wait();
}
-const BookmarkNode* BookmarkModel::GetNodeByID(int64 id) const {
- // TODO(sky): TreeNode needs a method that visits all nodes using a predicate.
- return GetNodeByID(&root_, id);
-}
-
const BookmarkNode* BookmarkModel::AddFolder(const BookmarkNode* parent,
int index,
const base::string16& title) {
@@ -817,19 +812,6 @@ BookmarkNode* BookmarkModel::AddNode(BookmarkNode* parent,
return node;
}
-const BookmarkNode* BookmarkModel::GetNodeByID(const BookmarkNode* node,
- int64 id) const {
- if (node->id() == id)
- return node;
-
- for (int i = 0, child_count = node->child_count(); i < child_count; ++i) {
- const BookmarkNode* result = GetNodeByID(node->GetChild(i), id);
- if (result)
- return result;
- }
- return NULL;
-}
-
bool BookmarkModel::IsValidIndex(const BookmarkNode* parent,
int index,
bool allow_end) {
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model.h ('k') | chrome/browser/bookmarks/bookmark_node_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698