Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2428073002: Revert of [Reland] Optimize blink scheduler with an intrusive heap (Closed)

Created:
4 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Reland] Optimize blink scheduler with an intrusive heap (patchset #12 id:240001 of https://codereview.chromium.org/2419793002/ ) Reason for revert: Looks like an assert is firing: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/318138 Original issue's description: > [Reland] Optimize blink scheduler with an intrusive heap. > > This shows a ~10% improvement on the TaskQueueManagerPerfTest > micro benchmark. > > Alternatives considered: A flat map/set > https://codereview.chromium.org/2396533004/ > > BUG= > > Committed: https://crrev.com/36d98e3b544f310943986dcaa98beabacdbccc96 > Committed: https://crrev.com/1e13bd23dd2aac48f6bbcce65a1c56b14d5254ef > Cr-Original-Commit-Position: refs/heads/master@{#425647} > Cr-Commit-Position: refs/heads/master@{#425930} TBR=altimin@chromium.org,haraken@chromium.org,skyostil@chromium.org,yutak@chromium.org,ojan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/95c8fde95ad889b9894f969bca56697201fec5e2 Cr-Commit-Position: refs/heads/master@{#425992}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
alex clarke (OOO till 29th)
Created Revert of [Reland] Optimize blink scheduler with an intrusive heap
4 years, 2 months ago (2016-10-18 16:55:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428073002/1
4 years, 2 months ago (2016-10-18 16:55:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 16:57:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95c8fde95ad889b9894f969bca56697201fec5e2 Cr-Commit-Position: refs/heads/master@{#425992}
4 years, 2 months ago (2016-10-18 16:59:29 UTC) #7
haraken
4 years, 2 months ago (2016-10-18 18:00:23 UTC) #8
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698