Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837
Committed: https://crrev.com/e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b
Cr-Commit-Position: refs/heads/master@{#427073}

[rwlbuis, 2016-10-18 15:24:04]

Description was changed from

==========
deleteRow WIP

BUG=
==========

to

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

[rwlbuis, 2016-10-18 15:24:42]

Description was changed from

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

to

==========
[WIP]Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

[rwlbuis, 2016-10-18 15:24:49]

Description was changed from

==========
[WIP]Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

to

==========
[WIP] Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

[rwlbuis, 2016-10-18 15:28:15]

rob.buis@samsung.com changed reviewers:
+ foolip@chromium.org

[rwlbuis, 2016-10-18 15:28:15]

Not up for review yet, but I figured it would be nice to have this change ready
for when the spec changes.

I guess this needs a bug?

Note that even today there is a problem, as in the scenario we are trying to fix
we get:
"The index provided (-1) is greater than the number of rows in the table (0).
Luckily with this change we avoid this false statement:)

[rwlbuis, 2016-10-18 15:42:00]

On 2016/10/18 15:28:15, rwlbuis wrote:
> Not up for review yet, but I figured it would be nice to have this change
ready
> for when the spec changes.
> 
> I guess this needs a bug?

Also, since this shows up green, maybe better to include the test updates from:
https://github.com/w3c/web-platform-tests/pull/4001

[rwlbuis, 2016-10-20 11:56:11]

Description was changed from

==========
[WIP] Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

to

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

[rwlbuis, 2016-10-20 11:57:20]

On 2016/10/18 15:42:00, rwlbuis wrote:
> On 2016/10/18 15:28:15, rwlbuis wrote:
> > Not up for review yet, but I figured it would be nice to have this change
> ready
> > for when the spec changes.
> > 
> > I guess this needs a bug?
> 
> Also, since this shows up green, maybe better to include the test updates
from:
> https://github.com/w3c/web-platform-tests/pull/4001

Since this has now been merged, I'll try to include it in this patch.

[foolip, 2016-10-20 13:57:01]

foolip@chromium.org changed reviewers:
+ qyearsley@chromium.org

[foolip, 2016-10-20 13:57:02]

qyearsley@, would it be best for Rob to just wait for your next import, does it
generally happen daily now?

[rwlbuis, 2016-10-20 14:36:58]

Description was changed from

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.
==========

to

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837
==========

[rwlbuis, 2016-10-20 14:38:53]

On 2016/10/20 13:57:02, foolip wrote:
> qyearsley@, would it be best for Rob to just wait for your next import, does
it
> generally happen daily now?

I am testing the test changes right now just to double-check. But indeed it may
be easier for this patch to go in after a general import.

BTW I also added a bug (crbug.com/657837).

[qyearsley, 2016-10-20 16:29:54]

On 2016/10/20 at 13:57:02, foolip wrote:
> qyearsley@, would it be best for Rob to just wait for your next import, does
it generally happen daily now?

I'm expecting the next successful import to be today or tomorrow, but imports
don't generally happen daily yet...

[rwlbuis, 2016-10-20 22:20:01]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2016-10-24 13:27:28]

@foolip I think this is ready for review now, I adjusted the patch now that the
updated wpt tests landed.

[foolip, 2016-10-24 13:33:12]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-24 13:33:13]

lgtm

[commit-bot: I haz the power, 2016-10-24 13:33:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:09:28]

Description was changed from

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837
==========

to

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837
==========

[commit-bot: I haz the power, 2016-10-24 15:09:31]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-24 15:12:50]

Description was changed from

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837
==========

to

==========
Update table.deleteRow(-1) to latest spec

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837

Committed: https://crrev.com/e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b
Cr-Commit-Position: refs/heads/master@{#427073}
==========

[commit-bot: I haz the power, 2016-10-24 15:12:51]

Patchset 2 (id:??) landed as
https://crrev.com/e9faa823cc6e16ca6cc9570d4c54a7e8dc8cf56b
Cr-Commit-Position: refs/heads/master@{#427073}