third_party/WebKit/Source/core/html/HTMLTableElement.cpp - Issue 2427963004: Update table.deleteRow(-1) to latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2427963004: Update table.deleteRow(-1) to latest spec (Closed)

Patch Set: Retry now new imported tests are there Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

index 6f608f4bb99e79502b2d532a1ed7e522b4ed3398..23cfa78d85d8d39b1c60229ae08aadf51b00091a 100644

--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

@@ -234,6 +234,8 @@ void HTMLTableElement::deleteRow(int index, ExceptionState& exceptionState) {

int i = 0;

if (index == -1) {

row = HTMLTableRowsCollection::lastRow(*this);

+ if (!row)

+ return;

} else {

for (i = 0; i <= index; ++i) {

row = HTMLTableRowsCollection::rowAfter(*this, row);