Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2427913002: Reduce usage of FOR_EACH_OBSERVER macro in components/invalidation (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in components/invalidation Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a Cr-Commit-Position: refs/heads/master@{#426096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M components/browser_sync/profile_sync_service.cc View 3 chunks +16 lines, -15 lines 0 comments Download
M components/invalidation/impl/invalidation_logger.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M components/invalidation/impl/invalidator_registrar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/ticl_settings_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Eric Willigers
4 years, 2 months ago (2016-10-18 08:50:35 UTC) #2
pavely
lgtm
4 years, 2 months ago (2016-10-18 17:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427913002/1
4 years, 2 months ago (2016-10-18 23:49:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 00:08:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b2ea16259b449afdc068feffcbe6d59df6fb39a
Cr-Commit-Position: refs/heads/master@{#426096}

Powered by Google App Engine
This is Rietveld 408576698