components/invalidation/impl/sync_system_resources.cc - Issue 2427913002: Reduce usage of FOR_EACH_OBSERVER macro in components/invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/sync_system_resources.cc

Issue 2427913002: Reduce usage of FOR_EACH_OBSERVER macro in components/invalidation (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/invalidation/impl/sync_system_resources.cc

diff --git a/components/invalidation/impl/sync_system_resources.cc b/components/invalidation/impl/sync_system_resources.cc

index f4f04e0f2605fa0b8032661901a9ca4ae17885c0..3cd65e74e0d0dbfb6d95fc93e73247a653a14109 100644

--- a/components/invalidation/impl/sync_system_resources.cc

+++ b/components/invalidation/impl/sync_system_resources.cc

@@ -193,8 +193,8 @@ void SyncNetworkChannel::NotifyNetworkStatusChange(bool online) {

void SyncNetworkChannel::NotifyChannelStateChange(

InvalidatorState invalidator_state) {

- FOR_EACH_OBSERVER(Observer, observers_,

- OnNetworkChannelStateChanged(invalidator_state));

+ for (auto& observer : observers_)

+ observer.OnNetworkChannelStateChanged(invalidator_state);

}

bool SyncNetworkChannel::DeliverIncomingMessage(const std::string& message) {