Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2427803002: [Sync] Replacing NULL with nullptr in code and null in comments for components/sync/ (Closed)

Created:
4 years, 2 months ago by skym
Modified:
4 years, 2 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, cbentzel+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Replacing NULL with nullptr in code and null in comments for components/sync/ BUG=656773 Committed: https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a Cr-Commit-Position: refs/heads/master@{#425788}

Patch Set 1 #

Patch Set 2 : Rebase and fixing conflict. #

Total comments: 4

Patch Set 3 : Fixing start of sentence capitlization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -255 lines) Patch
M components/sync/base/cancelation_signal.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/cancelation_signal.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/base/cryptographer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/enum_set.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/sync_prefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/base/sync_prefs.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/base/weak_handle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/about_sync_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/about_sync_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/directory_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_generic_change_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/generic_change_processor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/browser_thread_model_worker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/model_association_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/non_ui_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/shared_change_processor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_api_component_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_policy_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/driver/ui_data_type_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/ui_data_type_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine/attachments/attachment_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/attachments/attachment_store_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/engine_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/engine/model_safe_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/net/http_bridge.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M components/sync/engine/net/http_bridge_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M components/sync/engine/sync_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/engine_impl/apply_control_data_updates_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/engine_impl/attachments/attachment_downloader_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/commit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/commit_contributor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/cycle/directory_type_debug_info_emitter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/cycle/sync_cycle.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/directory_commit_contribution.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/directory_update_handler_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/js_mutation_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/net/server_connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/net/server_connection_manager.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/sync/engine_impl/net/sync_server_connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/sync_encryption_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 8 chunks +15 lines, -13 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/engine_impl/syncer_proto_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/syncer_proto_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/syncer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/test_entry_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/fake_syncable_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/syncable_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/model_impl/attachments/attachment_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/attachments/attachment_service_impl_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/syncable/base_transaction.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/change_record_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/directory.h View 7 chunks +7 lines, -7 lines 0 comments Download
M components/sync/syncable/directory.cc View 13 chunks +16 lines, -15 lines 0 comments Download
M components/sync/syncable/directory_backing_store.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/syncable/directory_backing_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/directory_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/sync/syncable/entry.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/entry_kernel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/entry_kernel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/entry_kernel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/model_neutral_mutable_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/mutable_entry.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/syncable/nigori_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/parent_child_index.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/read_node.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/syncable/read_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/sync_db_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/syncable_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/syncable/syncable_write_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/test_user_share.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/write_node.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/syncable/write_node.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/syncable/write_transaction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/test/engine/fake_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/engine/mock_connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/engine/mock_connection_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/test/fake_server/android/fake_server_helper_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/fake_server.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/fake_server_verifier.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/tools/sync_client.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M components/sync/tools/sync_listen_notifications.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/tools/testserver/run_sync_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
skym
PTAL
4 years, 2 months ago (2016-10-17 20:18:40 UTC) #5
maxbogue
lgtm w/ two little nits. Yay for keeping the house tidy! https://codereview.chromium.org/2427803002/diff/20001/components/sync/driver/glue/sync_backend_host_core.cc File components/sync/driver/glue/sync_backend_host_core.cc (right): ...
4 years, 2 months ago (2016-10-17 20:33:14 UTC) #7
skym
https://codereview.chromium.org/2427803002/diff/20001/components/sync/driver/glue/sync_backend_host_core.cc File components/sync/driver/glue/sync_backend_host_core.cc (right): https://codereview.chromium.org/2427803002/diff/20001/components/sync/driver/glue/sync_backend_host_core.cc#newcode469 components/sync/driver/glue/sync_backend_host_core.cc:469: if (!sync_manager_->GetUserShare()) { // null in some tests. On ...
4 years, 2 months ago (2016-10-17 20:36:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427803002/40001
4 years, 2 months ago (2016-10-17 20:36:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 22:13:18 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:14:47 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a
Cr-Commit-Position: refs/heads/master@{#425788}

Powered by Google App Engine
This is Rietveld 408576698