components/sync/model_impl/attachments/attachment_service_impl_unittest.cc - Issue 2427803002: [Sync] Replacing NULL with nullptr in code and null in comments for components/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model_impl/attachments/attachment_service_impl_unittest.cc

Issue 2427803002: [Sync] Replacing NULL with nullptr in code and null in comments for components/sync/ (Closed)

Patch Set: Fixing start of sentence capitlization. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/model_impl/attachments/attachment_service_impl.h ('k') | components/sync/protocol/proto_value_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/model_impl/attachments/attachment_service_impl_unittest.cc

diff --git a/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc b/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc

index 446a6a9865590ef45b5172be2229d6f543490ad3..e9cc8a95b029d18c2a38786638290228b8f412c0 100644

--- a/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc

+++ b/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc

@@ -427,7 +427,7 @@ TEST_F(AttachmentServiceImplTest, GetOrDownload_NoDownloader) {

// No downloader.

InitializeAttachmentService(

base::WrapUnique<MockAttachmentUploader>(new MockAttachmentUploader()),

- base::WrapUnique<MockAttachmentDownloader>(NULL), this);

+ base::WrapUnique<MockAttachmentDownloader>(nullptr), this);

AttachmentIdList attachment_ids;

attachment_ids.push_back(AttachmentId::Create(0, 0));

@@ -481,7 +481,7 @@ TEST_F(AttachmentServiceImplTest, UploadAttachments_Success) {

TEST_F(AttachmentServiceImplTest, UploadAttachments_Success_NoDelegate) {

InitializeAttachmentService(base::MakeUnique<MockAttachmentUploader>(),

base::MakeUnique<MockAttachmentDownloader>(),

- NULL); // No delegate.

+ nullptr); // No delegate.

AttachmentIdList attachment_ids;

attachment_ids.push_back(AttachmentId::Create(0, 0));

@@ -549,7 +549,7 @@ TEST_F(AttachmentServiceImplTest, UploadAttachments_AllMissingFromStore) {

}

TEST_F(AttachmentServiceImplTest, UploadAttachments_NoUploader) {

- InitializeAttachmentService(base::WrapUnique<MockAttachmentUploader>(NULL),

+ InitializeAttachmentService(base::WrapUnique<MockAttachmentUploader>(nullptr),

base::MakeUnique<MockAttachmentDownloader>(),

this);