Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2427743004: Improve compile time for 'Blimp Client Engine Integration' bot (Closed)

Created:
4 years, 2 months ago by shenghuazhang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jbudorick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve compile time for 'Blimp Client Engine Integration' bot Add 'use_goma = true' for gn args. BUG=656837 Committed: https://crrev.com/6b9fe5c1b2e37c4a6cb9088f23377162b7fd2924 Cr-Commit-Position: refs/heads/master@{#426027}

Patch Set 1 #

Patch Set 2 : case comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/args/bots/chromium.fyi/blimp_client_rel.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/args/bots/chromium.fyi/blimp_engine_rel.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
shenghuazhang
4 years, 2 months ago (2016-10-18 00:52:10 UTC) #2
mikecase (-- gone --)
I would name the files like... build/args/bots/chromium.fyi/blimp_client_bot_rel.gn ... if you take this approach. Alternatively you ...
4 years, 2 months ago (2016-10-18 01:05:48 UTC) #3
mikecase (-- gone --)
wait, maybe just add... use_goma = true ...to blimp_client_rel.gn I just noticed these configs are ...
4 years, 2 months ago (2016-10-18 01:09:25 UTC) #4
shenghuazhang
Thanks for the reconsidering! I modify the two gn files simply in this patch.
4 years, 2 months ago (2016-10-18 01:25:30 UTC) #5
mikecase (-- gone --)
non-OWNER lgtm
4 years, 2 months ago (2016-10-18 01:36:22 UTC) #6
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-18 01:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427743004/20001
4 years, 2 months ago (2016-10-18 18:54:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 19:55:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b9fe5c1b2e37c4a6cb9088f23377162b7fd2924
Cr-Commit-Position: refs/heads/master@{#426027}

Powered by Google App Engine
This is Rietveld 408576698