build/args/bots/chromium.fyi/blimp_engine_rel.gn - Issue 2427743004: Improve compile time for 'Blimp Client Engine Integration' bot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/args/bots/chromium.fyi/blimp_engine_rel.gn

Issue 2427743004: Improve compile time for 'Blimp Client Engine Integration' bot (Closed)

Patch Set: case comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 import("//build/args/blimp_engine.gn")	1 import("//build/args/blimp_engine.gn")

2	2

3 # release + official + DCHECKs is a weird combination of arguments!	3 # release + official + DCHECKs is a weird combination of arguments!

4 # However, it's an attempt to both:	4 # However, it's an attempt to both:

5 # - emulate how the engine will be deployed	5 # - emulate how the engine will be deployed

6 # - catch as many errors as possible	6 # - catch as many errors as possible

7 # If it proves to be less than entirely stable, drop official and just do	7 # If it proves to be less than entirely stable, drop official and just do

8 # release + DCHECKs	8 # release + DCHECKs

9 is_debug = false	9 is_debug = false

10 is_official_build = true	10 is_official_build = true

11 dcheck_always_on = true	11 dcheck_always_on = true

	12 use_goma = true

OLD	NEW

« no previous file with comments | « build/args/bots/chromium.fyi/blimp_client_rel.gn ('k') | no next file » | no next file with comments »