Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2427743003: MD Settings: fix double-tap to hide advanced bug (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix double-tap to hide advanced bug R=dpapad@chromium.org BUG=650951 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bb372ed35e94c5b140a09a3190cb4cfd058e6522 Cr-Commit-Position: refs/heads/master@{#425856}

Patch Set 1 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/settings_ui_browsertest.js View 2 chunks +37 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Dan Beam
4 years, 2 months ago (2016-10-18 00:40:32 UTC) #4
dpapad
LGTM
4 years, 2 months ago (2016-10-18 00:48:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427743003/40001
4 years, 2 months ago (2016-10-18 00:54:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-10-18 02:06:35 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:08:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb372ed35e94c5b140a09a3190cb4cfd058e6522
Cr-Commit-Position: refs/heads/master@{#425856}

Powered by Google App Engine
This is Rietveld 408576698