Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/test/data/webui/settings/settings_ui_browsertest.js

Issue 2427743003: MD Settings: fix double-tap to hide advanced bug (Closed)
Patch Set: nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_ui_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_ui_browsertest.js b/chrome/test/data/webui/settings/settings_ui_browsertest.js
index bc4401457188b8547f476d08435d7abb20644376..7d653fd583154b51eeafdee7dd0b1d14fedfc6a4 100644
--- a/chrome/test/data/webui/settings/settings_ui_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_ui_browsertest.js
@@ -32,6 +32,12 @@ TEST_F('SettingsUIBrowserTest', 'MAYBE_All', function() {
suiteSetup(function() {
ui = assert(document.querySelector('settings-ui'));
+ ui.$.drawerTemplate.restamp = true;
+ });
+
+ setup(function() {
+ ui.$.drawerTemplate.if = false;
+ Polymer.dom.flush();
});
test('basic', function() {
@@ -74,6 +80,37 @@ TEST_F('SettingsUIBrowserTest', 'MAYBE_All', function() {
done();
});
});
+
+ test('advanced UIs stay in sync', function() {
+ var main = ui.$$('settings-main');
+ assertTrue(!!main);
+
+ assertFalse(!!ui.$$('settings-menu'));
+ assertFalse(ui.advancedOpened_);
+ assertFalse(main.advancedToggleExpanded);
+
+ main.advancedToggleExpanded = true;
+ Polymer.dom.flush();
+
+ assertFalse(!!ui.$$('settings-menu'));
+ assertTrue(ui.advancedOpened_);
+ assertTrue(main.advancedToggleExpanded);
+
+ ui.$.drawerTemplate.if = true;
+ Polymer.dom.flush();
+
+ var menu = ui.$$('settings-menu');
+ assertTrue(!!menu);
+ assertTrue(menu.advancedOpened);
+
+ MockInteractions.tap(menu.$$('#advancedPage .menu-trigger'));
+ Polymer.dom.flush();
+
+ // Check that all values are updated in unison.
+ assertFalse(menu.advancedOpened);
+ assertFalse(ui.advancedOpened_);
+ assertFalse(main.advancedToggleExpanded);
+ });
});
mocha.run();
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698