more skslc hardening

more skslc hardening

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2427693002

Committed: https://skia.googlesource.com/skia/+/ea4567c1b080361b43eb0f52bb63e33f858baf94

[ethannicholas, 2016-10-17 14:33:24]

Description was changed from

==========
more skslc hardening

BUG=skia:
==========

to

==========
more skslc hardening

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2427693002
==========

[ethannicholas, 2016-10-17 14:38:23]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 14:38:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:58:39]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-10-17 15:05:14]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 15:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ethannicholas, 2016-10-17 15:09:01]

ethannicholas@google.com changed reviewers:
+ benjaminwagner@google.com

[ethannicholas, 2016-10-17 15:09:02]

Fixes to everything found by the fuzzer this weekend.

[commit-bot: I haz the power, 2016-10-17 15:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:26:29]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-10-17 15:30:36]

https://codereview.chromium.org/2427693002/diff/20001/src/sksl/SkSLIRGenerato...
File src/sksl/SkSLIRGenerator.cpp (left):

https://codereview.chromium.org/2427693002/diff/20001/src/sksl/SkSLIRGenerato...
src/sksl/SkSLIRGenerator.cpp:767: // FIXME: incorrect for shift operations
I think this still applies.

https://codereview.chromium.org/2427693002/diff/20001/src/sksl/SkSLIRGenerato...
File src/sksl/SkSLIRGenerator.cpp (right):

https://codereview.chromium.org/2427693002/diff/20001/src/sksl/SkSLIRGenerato...
src/sksl/SkSLIRGenerator.cpp:779: if (left.canCoerceTo(right) && (left.kind() ==
Type::kScalar_Kind ||
I don't think this is correct for the FOOEQ cases. E.g.:
float x = 1.0;
int y = 1;
y *= x;

Left is int, right is float, and this condition is true, but I think in this
case the function should return false.

[dogben, 2016-10-17 17:27:57]

lgtm

https://codereview.chromium.org/2427693002/diff/40001/tests/SkSLErrorTest.cpp
File tests/SkSLErrorTest.cpp (right):

https://codereview.chromium.org/2427693002/diff/40001/tests/SkSLErrorTest.cpp...
tests/SkSLErrorTest.cpp:151: "void main() { ivec3 x = ivec3(0); x *= 1.0; }",
Would this be OK if it were vec instead of ivec? Might be worth testing.

[ethannicholas, 2016-10-17 18:01:56]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-10-17 18:01:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/2427693002/#ps60001
(title: "added another test")

[commit-bot: I haz the power, 2016-10-17 18:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 18:24:43]

Description was changed from

==========
more skslc hardening

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2427693002
==========

to

==========
more skslc hardening

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2427693002

Committed:
https://skia.googlesource.com/skia/+/ea4567c1b080361b43eb0f52bb63e33f858baf94
==========

[commit-bot: I haz the power, 2016-10-17 18:24:44]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ea4567c1b080361b43eb0f52bb63e33f858baf94