Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/sksl/ir/SkSLTypeReference.h

Issue 2427693002: more skslc hardening (Closed)
Patch Set: added another test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/sksl/SkSLIRGenerator.cpp ('k') | tests/SkSLErrorTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SKSL_TYPEREFERENCE 8 #ifndef SKSL_TYPEREFERENCE
9 #define SKSL_TYPEREFERENCE 9 #define SKSL_TYPEREFERENCE
10 10
11 #include "SkSLContext.h" 11 #include "SkSLContext.h"
12 #include "SkSLExpression.h" 12 #include "SkSLExpression.h"
13 13
14 namespace SkSL { 14 namespace SkSL {
15 15
16 /** 16 /**
17 * Represents an identifier referring to a type. This is an intermediate value: TypeReferences are 17 * Represents an identifier referring to a type. This is an intermediate value: TypeReferences are
18 * always eventually replaced by Constructors in valid programs. 18 * always eventually replaced by Constructors in valid programs.
19 */ 19 */
20 struct TypeReference : public Expression { 20 struct TypeReference : public Expression {
21 TypeReference(const Context& context, Position position, const Type& type) 21 TypeReference(const Context& context, Position position, const Type& type)
22 : INHERITED(position, kTypeReference_Kind, *context.fInvalid_Type) 22 : INHERITED(position, kTypeReference_Kind, *context.fInvalid_Type)
23 , fValue(type) {} 23 , fValue(type) {}
24 24
25 std::string description() const override { 25 std::string description() const override {
26 ASSERT(false); 26 return fValue.name();
27 return "<type>";
28 } 27 }
29 28
30 const Type& fValue; 29 const Type& fValue;
31 30
32 typedef Expression INHERITED; 31 typedef Expression INHERITED;
33 }; 32 };
34 33
35 } // namespace 34 } // namespace
36 35
37 #endif 36 #endif
OLDNEW
« no previous file with comments | « src/sksl/SkSLIRGenerator.cpp ('k') | tests/SkSLErrorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698