Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2427673004: [intrinsics] Nuke %HasCachedArrayIndex and %GetCachedArrayIndex. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Nuke %HasCachedArrayIndex and %GetCachedArrayIndex. These intrinsics are unused now, and so we can drop all the code in fullcodegen and Crankshaft that deals with those. TurboFan and Ignition never tried to optimize those. R=mstarzinger@chromium.org BUG=v8:5049 Committed: https://crrev.com/6c85285b98f06b4b5a98c599b16257c7a12fff45 Cr-Commit-Position: refs/heads/master@{#40401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1304 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -34 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -41 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-18 12:46:32 UTC) #1
Benedikt Meurer
Hey Michi, Dead code in FCG/CS! Remove all the deprecated code! Please take a look. ...
4 years, 2 months ago (2016-10-18 12:47:41 UTC) #4
Michael Starzinger
LGTM. Nice! I'm lovin' it. :)
4 years, 2 months ago (2016-10-18 12:50:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427673004/1
4 years, 2 months ago (2016-10-18 12:54:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 13:13:19 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 13:13:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c85285b98f06b4b5a98c599b16257c7a12fff45
Cr-Commit-Position: refs/heads/master@{#40401}

Powered by Google App Engine
This is Rietveld 408576698