Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2424403002: [builtins] Migrate Number.parseInt to TurboFan builtin. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Number.parseInt to TurboFan builtin. R=epertoso@chromium.org BUG=v8:5049 Committed: https://crrev.com/1b4e0fcaea578cc03566e7553491b00aa3f1134f Cr-Commit-Position: refs/heads/master@{#40399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -61 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-number.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -47 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +23 lines, -11 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-18 12:03:30 UTC) #1
epertoso
lgtm
4 years, 2 months ago (2016-10-18 12:40:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424403002/1
4 years, 2 months ago (2016-10-18 12:41:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 12:44:52 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 12:45:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b4e0fcaea578cc03566e7553491b00aa3f1134f
Cr-Commit-Position: refs/heads/master@{#40399}

Powered by Google App Engine
This is Rietveld 408576698