pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart - Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/scheduled_test/lib/scheduled_process.dart ('k') | pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart » ('j') | pkg/scheduled_test/test/descriptor/async_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

diff --git a/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart b/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

index a1d63583a3193bf41c94e959d7fae5f40526f896..e5baf445d57b649364d18ad9908be78fcb9b9129 100644

--- a/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

+++ b/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

@@ -42,7 +42,7 @@ class DirectoryDescriptor extends Descriptor implements LoadableDescriptor {

if (parent == null) parent = defaultRoot;

var fullPath = path.join(parent, name);

if (!new Directory(fullPath).existsSync()) {

- throw "Directory not found: '$fullPath'.";

+ fail("Directory not found: '$fullPath'.");

}

return Future.wait(contents.map((entry) {

@@ -77,11 +77,11 @@ class DirectoryDescriptor extends Descriptor implements LoadableDescriptor {

var adjective = requiresReadable ? 'readable' : 'loadable';

if (matchingEntries.length == 0) {

- throw "Couldn't find a $adjective entry named '${split.first}' within "

- "'$name'.";

+ fail("Couldn't find a $adjective entry named '${split.first}' within "

+ "'$name'.");

} else if (matchingEntries.length > 1) {

- throw "Found multiple $adjective entries named '${split.first}' within "

- "'$name'.";

+ fail("Found multiple $adjective entries named '${split.first}' within "

+ "'$name'.");

} else {

var remainingPath = split.sublist(1);

if (remainingPath.isEmpty) {