Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: pkg/scheduled_test/lib/scheduled_process.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/lib/scheduled_process.dart
diff --git a/pkg/scheduled_test/lib/scheduled_process.dart b/pkg/scheduled_test/lib/scheduled_process.dart
index 4768c684fefe3ef83f668fe41e432224ec48a100..4b2830979e5ba63c3983b31207efce9d11352a9c 100644
--- a/pkg/scheduled_test/lib/scheduled_process.dart
+++ b/pkg/scheduled_test/lib/scheduled_process.dart
@@ -183,8 +183,8 @@ class ScheduledProcess {
exitCodeCompleter.complete(exitCode);
if (!_endExpected) {
- throw "Process '$description' ended earlier than scheduled "
- "with exit code $exitCode.";
+ fail("Process '$description' ended earlier than scheduled "
+ "with exit code $exitCode.");
}
}), "waiting to reach shouldExit() or kill() for process "
"'$description'");

Powered by Google App Engine
This is Rietveld 408576698