Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2427593003: Revert "[telemetry] Disable perf benchmarks that use BattOr tracing" (Closed)

Created:
4 years, 2 months ago by charliea (OOO until 10-5)
Modified:
4 years, 2 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org, rnephew (Reviews Here)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[telemetry] Disable perf benchmarks that use BattOr tracing" http://crbug.com/652384 should be resolved now that we've flashed all BattOrs in the lab with new firmware. This reverts commit e8e1256d25b5f8c0bf706f2b21b9d86ac7e5356d. BUG=652384 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/27499ad9143b1ccee534b1605a31f7aab11ba243 Cr-Commit-Position: refs/heads/master@{#426042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M tools/perf/benchmarks/battor.py View 3 chunks +2 lines, -12 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
charliea (OOO until 10-5)
4 years, 2 months ago (2016-10-17 23:53:47 UTC) #4
sullivan
lgtm
4 years, 2 months ago (2016-10-17 23:54:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427593003/1
4 years, 2 months ago (2016-10-17 23:55:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/659)
4 years, 2 months ago (2016-10-18 05:56:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427593003/1
4 years, 2 months ago (2016-10-18 15:30:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 20:59:18 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27499ad9143b1ccee534b1605a31f7aab11ba243
Cr-Commit-Position: refs/heads/master@{#426042}

Powered by Google App Engine
This is Rietveld 408576698