Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2427593003: Revert "[telemetry] Disable perf benchmarks that use BattOr tracing" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os
6 import re 5 import re
7 6
8 from core import perf_benchmark 7 from core import perf_benchmark
9 from telemetry import benchmark 8 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
11 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
12 import page_sets 11 import page_sets
13 12
14 13
15 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames() 14 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
(...skipping 11 matching lines...) Expand all
27 1) Be rearchitected such that it doesn't. This is the most preferred option. 26 1) Be rearchitected such that it doesn't. This is the most preferred option.
28 2) Be run in a separate test suite (e.g. memory). 27 2) Be run in a separate test suite (e.g. memory).
29 28
30 https://goo.gl/Jek2NL. 29 https://goo.gl/Jek2NL.
31 """ 30 """
32 31
33 def CreateTimelineBasedMeasurementOptions(self): 32 def CreateTimelineBasedMeasurementOptions(self):
34 options = timeline_based_measurement.Options( 33 options = timeline_based_measurement.Options(
35 chrome_trace_category_filter.ChromeTraceCategoryFilter()) 34 chrome_trace_category_filter.ChromeTraceCategoryFilter())
36 options.config.chrome_trace_config.category_filter.AddFilterString('rail') 35 options.config.chrome_trace_config.category_filter.AddFilterString('rail')
37 # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once 36 options.config.enable_battor_trace = True
38 # the BattOrs stop crashing as their SD cards fill up.
39 # crbug.com/652384
40 options.config.enable_battor_trace = (
41 os.environ.get('BUILDBOT_MASTERNAME') == 'chromium.perf.fyi')
42 options.config.enable_chrome_trace = True 37 options.config.enable_chrome_trace = True
43 options.SetTimelineBasedMetrics(['clockSyncLatencyMetric', 'powerMetric']) 38 options.SetTimelineBasedMetrics(['clockSyncLatencyMetric', 'powerMetric'])
44 return options 39 return options
45 40
46 def CreateStorySet(self, options): 41 def CreateStorySet(self, options):
47 return page_sets.SystemHealthStorySet(platform=self.PLATFORM) 42 return page_sets.SystemHealthStorySet(platform=self.PLATFORM)
48 43
49 @classmethod 44 @classmethod
50 def ShouldTearDownStateAfterEachStoryRun(cls): 45 def ShouldTearDownStateAfterEachStoryRun(cls):
51 return True 46 return True
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 and load a blank page with multiprocess enabled. 184 and load a blank page with multiprocess enabled.
190 """ 185 """
191 186
192 def SetExtraBrowserOptions(self, options): 187 def SetExtraBrowserOptions(self, options):
193 options.AppendExtraBrowserArgs( 188 options.AppendExtraBrowserArgs(
194 ['--webview-sandboxed-renderer']) 189 ['--webview-sandboxed-renderer'])
195 190
196 @classmethod 191 @classmethod
197 def Name(cls): 192 def Name(cls):
198 return 'system_health.webview_startup_multiprocess' 193 return 'system_health.webview_startup_multiprocess'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/battor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698