Issue 2427563002: Call willInsertBody() in MediaDocument::createDocumentStructure()

Issue 2427563002: Call willInsertBody() in MediaDocument::createDocumentStructure() (Closed)

Created:
4 years, 2 months ago by wdzierzanowski

Modified:
4 years, 1 month ago

Reviewers:
esprehn

CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, Srirama

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Call willInsertBody() in MediaDocument::createDocumentStructure() Follow up on https://codereview.chromium.org/1343493002 and add the same willInsertBody() call that ImageDocument has. Committed: https://crrev.com/f0988b48c0d81921bed0eca7eb095f7ec15d2eb8 Cr-Commit-Position: refs/heads/master@{#427312}

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/html/MediaDocument.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wdzierzanowski

esprehn@, PTAL. This fixes a bug in Opera, but I can't reproduce it in vanilla ...

4 years, 2 months ago (2016-10-17 10:37:17 UTC) #2

wdzierzanowski

On 2016/10/24 18:16:57, esprehn wrote: > Test? See my question above :) > What's the ...

4 years, 1 month ago (2016-10-24 18:55:45 UTC) #5

esprehn

Oh I see, you could do this with a unit test that installs it's own ...

4 years, 1 month ago (2016-10-25 03:11:45 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427563002/1

4 years, 1 month ago (2016-10-25 07:02:24 UTC) #9

commit-bot: I haz the power

4 years, 1 month ago (2016-10-25 10:45:32 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f0988b48c0d81921bed0eca7eb095f7ec15d2eb8
Cr-Commit-Position: refs/heads/master@{#427312}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages