Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1343493002:
Fix progressive rendering of image documents (Closed)
|
Created:
5 years, 3 months ago by esprehn Modified:
5 years, 3 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionFix progressive rendering of image documents
ImageDocument used to force a layout to resume commits, but after r200515 [1]
we no longer resume commits after every layout which broke progressive
rendering of image documents.
To fix this we make ImageDocument correctly call dispatchWillInsertBody in
ImageDocument::createDocumentStructure and remove the forced updateLayout()
hack from before.
[1] https://src.chromium.org/viewvc/blink?view=rev&revision=200515
BUG=528827
Committed: https://crrev.com/0527ee34331308fb3c5f2fec709ac3551b9a704a
git-svn-id: svn://svn.chromium.org/blink/trunk@202192 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #
Messages
Total messages: 42 (18 generated)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
esprehn@chromium.org changed reviewers: + dglazkov@chromium.org, noel@chromium.org, pdr@chromium.org, yoav@yoav.ws
lgtm
LGTM
On 2015/09/11 at 21:07:52, dglazkov wrote: > lgtm >_> quickdraw dglazkov, you win this round. Best watch'a back next time.
On 2015/09/11 at 21:10:55, pdr wrote: > On 2015/09/11 at 21:07:52, dglazkov wrote: > > lgtm > > >_> quickdraw dglazkov, you win this round. Best watch'a back next time. http://giphy.com/gifs/humor-cowboy-W324P8HR8tyfu
The CQ bit was unchecked by esprehn@chromium.org
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343493002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202192
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0527ee34331308fb3c5f2fec709ac3551b9a704a |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
