Issue 2427543002: [MediaControls] Hide overflow menu and closed caption list when clicking on some MediaControl eleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2427543002: [MediaControls] Hide overflow menu and closed caption list when clicking on some MediaControl eleme… (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

[MediaControls] Hide overflow menu and closed caption list when clicking on some MediaControl elements Some MediaControl elements trap click events and prevent the event being fired on parent elements. This CL adds additional EventHandlers to these event-trapping elements to hide MediaControls correctly. BUG=654637 Review-Url: https://codereview.chromium.org/2414653002 Cr-Commit-Position: refs/heads/master@{#425573} (cherry picked from commit 9e83c349b6790b8b5514cc40df8c7be4cf4f2e29)

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -3 lines)			Patch
A +	third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControls.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp	View	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Zhiqiang Zhang (Slow)

4 years, 2 months ago (2016-10-17 09:33:27 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
52777f78d5a80a2b197399b11e08c4e2581d8f6b.

Expand Messages | Collapse Messages