Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2414653002: [MediaControls] Hide menus when clicking on some MediaControl elements (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaControls] Hide overflow menu and closed caption list when clicking on some MediaControl elements Some MediaControl elements trap click events and prevent the event being fired on parent elements. This CL adds additional EventHandlers to these event-trapping elements to hide MediaControls correctly. BUG=654637 Committed: https://crrev.com/9e83c349b6790b8b5514cc40df8c7be4cf4f2e29 Cr-Commit-Position: refs/heads/master@{#425573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
A + third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-panel.html View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Zhiqiang Zhang (Slow)
4 years, 2 months ago (2016-10-12 10:39:09 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 2 months ago (2016-10-15 18:04:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414653002/1
4 years, 2 months ago (2016-10-15 20:02:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 21:17:01 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 21:18:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e83c349b6790b8b5514cc40df8c7be4cf4f2e29
Cr-Commit-Position: refs/heads/master@{#425573}

Powered by Google App Engine
This is Rietveld 408576698