Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2427533002: [turbofan] Run load elimination prior to escape analysis. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run load elimination prior to escape analysis. Once the escape analysis ran, it'll be harder to eliminate a bunch of checks (for example map checks, which would currently block escape analysis, but that's about to be fixed). Also the escape analysis will have a lot less stress after the load elimination, which takes care of redundant loads and checks already. R=mstarzinger@chromium.org BUG=v8:5448 Committed: https://crrev.com/201e53fbe94c4c66f02db5db524d1e7e5ce01740 Cr-Commit-Position: refs/heads/master@{#40351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 09:22:07 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, here's the change to run load elimination first. Please take ...
4 years, 2 months ago (2016-10-17 09:25:22 UTC) #4
Michael Starzinger
LGTM.
4 years, 2 months ago (2016-10-17 09:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427533002/1
4 years, 2 months ago (2016-10-17 10:07:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 10:13:36 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:13:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201e53fbe94c4c66f02db5db524d1e7e5ce01740
Cr-Commit-Position: refs/heads/master@{#40351}

Powered by Google App Engine
This is Rietveld 408576698