Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2423913002: [turbofan] Manually smash the type on literal allocation. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Manually smash the type on literal allocation. Currently JSCreateLowering drops the type information for object literals, when inlining the JSCreateLiteralArray/Object nodes, which means we will not eliminate a couple of checks after the lowering. R=jarin@chromium.org Committed: https://crrev.com/e0b4b1b63f0df8f53d27d87a3566ca7f8988cd76 Cr-Commit-Position: refs/heads/master@{#40344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/compiler/js-create-lowering.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 08:34:56 UTC) #1
Benedikt Meurer
Hey Jaro, As discussed offline, manually annotate the Allocate nodes with types. Please take a ...
4 years, 2 months ago (2016-10-17 08:36:59 UTC) #4
Jarin
lgtm
4 years, 2 months ago (2016-10-17 09:03:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423913002/1
4 years, 2 months ago (2016-10-17 09:04:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 09:13:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:14:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0b4b1b63f0df8f53d27d87a3566ca7f8988cd76
Cr-Commit-Position: refs/heads/master@{#40344}

Powered by Google App Engine
This is Rietveld 408576698