Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2427433002: Workaround for setComposition styling clobber (Closed)

Created:
4 years, 2 months ago by Changwan Ryu
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Workaround for setComposition styling clobber In order to keep the previous text formatting when continuing typing on the word, this CL detects when the beginning of the IME commit is the same at what was there already, and restricts the write to only the character(s) at the end that actually changed. (This CL is based on aelias@'s CL: https://codereview.chromium.org/2073863003) BUG=620549 Review-Url: https://codereview.chromium.org/2372493002 Cr-Commit-Position: refs/heads/master@{#424716} (cherry picked from commit 993074d17afee685ced99283d7ffbe809fdb6f99) Committed: https://chromium.googlesource.com/chromium/src/+/518012b2b00f0296b957476c797528a9ea03391c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 4 chunks +188 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +70 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 2 months ago (2016-10-17 01:28:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
518012b2b00f0296b957476c797528a9ea03391c.

Powered by Google App Engine
This is Rietveld 408576698