Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2073863003: [WIP, not for review] Workaround for setComposition styling clobber (Closed)

Created:
4 years, 6 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 2 months ago
Reviewers:
Changwan Ryu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP, not for review] Workaround for setComposition styling clobber BUG=620549

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -13 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 3 chunks +51 lines, -13 lines 2 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Changwan Ryu
https://codereview.chromium.org/2073863003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right): https://codereview.chromium.org/2073863003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp#newcode320 third_party/WebKit/Source/core/editing/InputMethodController.cpp:320: bool backspacing = text.length() > 0 && text == ...
4 years, 3 months ago (2016-09-07 04:14:39 UTC) #2
aelias_OOO_until_Jul13
https://codereview.chromium.org/2073863003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp File third_party/WebKit/Source/core/editing/InputMethodController.cpp (right): https://codereview.chromium.org/2073863003/diff/1/third_party/WebKit/Source/core/editing/InputMethodController.cpp#newcode320 third_party/WebKit/Source/core/editing/InputMethodController.cpp:320: bool backspacing = text.length() > 0 && text == ...
4 years, 3 months ago (2016-09-07 05:11:49 UTC) #3
aelias_OOO_until_Jul13
4 years, 2 months ago (2016-09-28 23:59:16 UTC) #4
Message was sent while issue was closed.
For the record, closed this because yabinh@ is polishing this up for landing in
https://codereview.chromium.org/2372493002/

Powered by Google App Engine
This is Rietveld 408576698