Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2427423003: Fix incorrect DCHECK in task manager's WebContentsEntry. (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
3 years, 7 months ago
Reviewers:
afakhry
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect DCHECK in task manager's WebContentsEntry. With out-of-process iframes, it is not safe to assume that an unresponsive event comes from the main frame's widget/process. BUG=623228 TEST=See bug for repro steps. Review-Url: https://codereview.chromium.org/2427423003 Cr-Commit-Position: refs/heads/master@{#468335} Committed: https://chromium.googlesource.com/chromium/src/+/0f90533beb304bab626934c8948ba1d002527a5e

Patch Set 1 : Initial patch #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -4 lines) Patch
M chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc View 1 2 chunks +62 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc View 1 2 chunks +14 lines, -4 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
afakhry
On 2016/10/19 12:01:07, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 1 month ago (2016-10-25 00:43:42 UTC) #6
Charlie Reis
On 2016/10/25 00:43:42, afakhry wrote: > On 2016/10/19 12:01:07, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-10-25 17:09:01 UTC) #9
Charlie Reis
Heh, certainly took me a while to get back to it, but I finally added ...
3 years, 7 months ago (2017-05-01 16:09:40 UTC) #14
afakhry
That was indeed a long while! :) LGTM.
3 years, 7 months ago (2017-05-01 16:29:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427423003/40001
3 years, 7 months ago (2017-05-01 17:01:44 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:07:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0f90533beb304bab626934c8948b...

Powered by Google App Engine
This is Rietveld 408576698