Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2427403002: Fix unexpected metrics preference resetting. (Closed)

Created:
4 years, 2 months ago by hidehiko
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix unexpected metrics preference resetting. Currently, if metrics preference is already enabled on arc_support extension starting, then the checkbox is hidden. Thus, isMetricsEnabled=false is sent onAgree and then it is disabled un-intentionally. This CL fixes the bug. BUG=656006 , b/32132303 TEST=Ran on test device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2413203003 Cr-Commit-Position: refs/heads/master@{#425334} (cherry picked from commit 6ecec1dcd1856abc9b37d94a460c4f96e047e5ba) Committed: https://chromium.googlesource.com/chromium/src/+/486eb87a797721af37ed1632754d64bd5df66a51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/arc_support/background.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hidehiko
4 years, 2 months ago (2016-10-19 04:01:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
486eb87a797721af37ed1632754d64bd5df66a51.

Powered by Google App Engine
This is Rietveld 408576698