Fix unexpected metrics preference resetting.

Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006
, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6ecec1dcd1856abc9b37d94a460c4f96e047e5ba
Cr-Commit-Position: refs/heads/master@{#425334}

[hidehiko, 2016-10-13 09:29:08]

Description was changed from

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=b/32132303
TEST=Ran on test device.
==========

to

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hidehiko, 2016-10-13 09:29:19]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 09:29:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-10-13 09:30:55]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org, xiyuan@chromium.org

[hidehiko, 2016-10-13 09:30:56]

PTAL.

This is M55 cherry-pick target.

[commit-bot: I haz the power, 2016-10-13 10:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 10:18:14]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-10-13 15:17:19]

cherry-pick targets must have a crbug in the commit description, instead of/in
addition to a b/ bug. otherwise you still need to create the crbug and won't be
autoapproved for merging once you meet the requirements.

other than that, lgtm.

[elijahtaylor1, 2016-10-13 16:20:48]

Do we have an integration test to verify the setting matches in Android what is
set on Chrome OS?  If not, please file an issue to create one, this is a very
important thing to not regress.

[xiyuan, 2016-10-13 21:30:39]

lgtm

[hidehiko, 2016-10-14 14:32:58]

Description was changed from

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hidehiko, 2016-10-14 14:34:12]

Thank you for review.
Filed a bug for cherry-pick: crbug.com/656006, and adding test:
crbug.com/656007.

Submitting.

[hidehiko, 2016-10-14 14:34:21]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-10-14 14:34:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 15:49:24]

Description was changed from

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-14 15:49:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 15:52:14]

Description was changed from

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix unexpected metrics preference resetting.

Currently, if metrics preference is already enabled on
arc_support extension starting, then the checkbox is
hidden. Thus, isMetricsEnabled=false is sent onAgree
and then it is disabled un-intentionally.

This CL fixes the bug.

BUG=656006, b/32132303
TEST=Ran on test device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6ecec1dcd1856abc9b37d94a460c4f96e047e5ba
Cr-Commit-Position: refs/heads/master@{#425334}
==========

[commit-bot: I haz the power, 2016-10-14 15:52:15]

Patchset 1 (id:??) landed as
https://crrev.com/6ecec1dcd1856abc9b37d94a460c4f96e047e5ba
Cr-Commit-Position: refs/heads/master@{#425334}