chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_storage.cc ('K') | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/extensions/lazy_background_page_apitest.cc » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

index 0a3be770b211ff976e9cd78122854752bc3bf518..d3b3d6fcfa21598c088448fc89becd912f7a7b02 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

@@ -601,7 +601,8 @@ bool BookmarkManagerPrivateCanEditFunction::RunImpl() {

}

bool BookmarkManagerPrivateRecordLaunchFunction::RunImpl() {

- RecordBookmarkLaunch(NULL, BOOKMARK_LAUNCH_LOCATION_MANAGER);

+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());

+ RecordBookmarkLaunch(model, NULL, BOOKMARK_LAUNCH_LOCATION_MANAGER);

return true;

}