Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4644)

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_utils.cc
diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc
index 01c00475b8983905cd1996c005f417eb3f488dc5..8492e994d36eb5adb7a88d1736ebed21e4598e89 100644
--- a/chrome/browser/bookmarks/bookmark_utils.cc
+++ b/chrome/browser/bookmarks/bookmark_utils.cc
@@ -10,6 +10,7 @@
#include "base/files/file_path.h"
#include "base/i18n/case_conversion.h"
#include "base/i18n/string_search.h"
+#include "base/metrics/user_metrics_action.h"
#include "base/prefs/pref_service.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
@@ -18,7 +19,6 @@
#include "components/bookmarks/core/common/bookmark_pref_names.h"
#include "components/query_parser/query_parser.h"
#include "components/user_prefs/pref_registry_syncable.h"
-#include "content/public/browser/user_metrics.h"
#include "net/base/net_util.h"
#include "ui/base/models/tree_node_iterator.h"
@@ -349,6 +349,7 @@ void DeleteBookmarkFolders(BookmarkModel* model,
}
void AddIfNotBookmarked(BookmarkModel* model,
+ BookmarkClient* client,
const GURL& url,
const base::string16& title) {
std::vector<const BookmarkNode*> bookmarks;
@@ -356,7 +357,7 @@ void AddIfNotBookmarked(BookmarkModel* model,
if (!bookmarks.empty())
return; // Nothing to do, a bookmark with that url already exists.
- content::RecordAction(base::UserMetricsAction("BookmarkAdded"));
+ client->RecordAction(base::UserMetricsAction("BookmarkAdded"));
const BookmarkNode* parent = model->GetParentForNewNodes();
model->AddURL(parent, parent->child_count(), title, url);
}

Powered by Google App Engine
This is Rietveld 408576698