Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2426923002: [stubs] Removes the BranchIf.*() methods from CodeAssembler, changes their uses to Branch(). (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Jarin, mythria, danno
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Removes the BranchIf.*() methods from CodeAssembler, changes their uses to Branch(). BranchIf and helpers were introduced when exporting the schedule from the RawMachineAssembler was not ensuring that the CFG was well-form. These methods, that were used to introduce blocks to ensure edge-split form, are now unnecessary. BUG= Committed: https://crrev.com/b6c152e967f3694d3201477f01ddff0038bbc395 Cr-Commit-Position: refs/heads/master@{#40402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -128 lines) Patch
M src/builtins/builtins-array.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M src/builtins/builtins-number.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 20 chunks +53 lines, -51 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/interpreter/interpreter.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
epertoso
4 years, 2 months ago (2016-10-18 11:46:19 UTC) #7
Jarin
lgtm
4 years, 2 months ago (2016-10-18 12:04:40 UTC) #10
danno
I like it. lgtm.
4 years, 2 months ago (2016-10-18 12:28:22 UTC) #11
mythria
Nice, lgtm.
4 years, 2 months ago (2016-10-18 13:24:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426923002/1
4 years, 2 months ago (2016-10-18 13:24:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 13:27:47 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 13:28:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6c152e967f3694d3201477f01ddff0038bbc395
Cr-Commit-Position: refs/heads/master@{#40402}

Powered by Google App Engine
This is Rietveld 408576698