Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: src/builtins/builtins-string.cc

Issue 2426923002: [stubs] Removes the BranchIf.*() methods from CodeAssembler, changes their uses to Branch(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-number.cc ('k') | src/code-stub-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 7
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/regexp/regexp-utils.h" 9 #include "src/regexp/regexp-utils.h"
10 10
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 285
286 assembler->Bind(&if_valueissame); 286 assembler->Bind(&if_valueissame);
287 { 287 {
288 // Advance to next character. 288 // Advance to next character.
289 var_offset.Bind( 289 var_offset.Bind(
290 assembler->IntPtrAdd(offset, assembler->IntPtrConstant(1))); 290 assembler->IntPtrAdd(offset, assembler->IntPtrConstant(1)));
291 } 291 }
292 assembler->Goto(&loop); 292 assembler->Goto(&loop);
293 293
294 assembler->Bind(&if_valueisnotsame); 294 assembler->Bind(&if_valueisnotsame);
295 assembler->BranchIf(assembler->Uint32LessThan(lhs_value, rhs_value), 295 assembler->Branch(assembler->Uint32LessThan(lhs_value, rhs_value),
296 &if_less, &if_greater); 296 &if_less, &if_greater);
297 } 297 }
298 298
299 assembler->Bind(&if_done); 299 assembler->Bind(&if_done);
300 { 300 {
301 // All characters up to the min length are equal, decide based on 301 // All characters up to the min length are equal, decide based on
302 // string length. 302 // string length.
303 Label if_lengthisequal(assembler), if_lengthisnotequal(assembler); 303 Label if_lengthisequal(assembler), if_lengthisnotequal(assembler);
304 assembler->Branch(assembler->SmiEqual(lhs_length, rhs_length), 304 assembler->Branch(assembler->SmiEqual(lhs_length, rhs_length),
305 &if_lengthisequal, &if_lengthisnotequal); 305 &if_lengthisequal, &if_lengthisnotequal);
306 306
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 Runtime::kThrowIncompatibleMethodReceiver, context, 1486 Runtime::kThrowIncompatibleMethodReceiver, context,
1487 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked( 1487 assembler->HeapConstant(assembler->factory()->NewStringFromAsciiChecked(
1488 "String Iterator.prototype.next", TENURED)), 1488 "String Iterator.prototype.next", TENURED)),
1489 iterator); 1489 iterator);
1490 assembler->Return(result); // Never reached. 1490 assembler->Return(result); // Never reached.
1491 } 1491 }
1492 } 1492 }
1493 1493
1494 } // namespace internal 1494 } // namespace internal
1495 } // namespace v8 1495 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins-number.cc ('k') | src/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698