Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 24269004: Reenable GrAAHairlinePathRenderer assert w/ fix (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

r11365 ("Fix" for hairline corner bugs - https://codereview.chromium.org/23708036/) altered the hairline line geometry but didn't update the outset on the device space bounding box. Since line caps are now added the outset needs to be a little larger.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improved comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 3 months ago (2013-09-19 13:19:49 UTC) #1
jvanverth1
https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (left): https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#oldcode741 src/gpu/GrAAHairLinePathRenderer.cpp:741: devBounds->outset(SK_Scalar1, SK_Scalar1); Why did this get removed? Is it ...
7 years, 3 months ago (2013-09-19 15:18:29 UTC) #2
robertphillips
https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (left): https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#oldcode741 src/gpu/GrAAHairLinePathRenderer.cpp:741: devBounds->outset(SK_Scalar1, SK_Scalar1); On 2013/09/19 15:18:29, JimVV wrote: > Why ...
7 years, 3 months ago (2013-09-19 16:03:45 UTC) #3
jvanverth1
lgtm + suggestion https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#newcode763 src/gpu/GrAAHairLinePathRenderer.cpp:763: } It's unclear why it's sqrt(1.25) ...
7 years, 3 months ago (2013-09-19 16:26:52 UTC) #4
robertphillips
7 years, 3 months ago (2013-09-19 16:37:00 UTC) #5
Message was sent while issue was closed.
committed as r11385

https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRende...
File src/gpu/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/24269004/diff/1/src/gpu/GrAAHairLinePathRende...
src/gpu/GrAAHairLinePathRenderer.cpp:763: }
On 2013/09/19 16:26:53, JimVV wrote:
> It's unclear why it's sqrt(1.25) -- maybe expand to sqrt(1^2 + 0.5^2)?

Done.

Powered by Google App Engine
This is Rietveld 408576698