Allow timeConstant=0 for setTargetAtTime

Allow timeConstant=0 for setTargetAtTime

setTargetAtTime should allow a time constant of 0.  This means the
output value jumps instantaneously to the target value at the start
time.

Spec: https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-AudioParam-float-target-double-startTime-float-timeConstant

BUG=630869
TEST=audioparam-setTarget-timeConstant-0.html,
     audiparam-exceptional-values.html

Remove test for timeConstant=0.

Committed: https://crrev.com/9f2135a54d2c7d6112f426a4a988e16a1c4ca9f2
Cr-Commit-Position: refs/heads/master@{#437614}

[Raymond Toy, 2016-10-18 20:16:41]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:17:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-10-18 20:37:04]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-10-18 20:37:05]

PTAL

[commit-bot: I haz the power, 2016-10-18 21:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:58:45]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-31 15:09:43]

Ping

[hongchan, 2016-10-31 20:50:43]

lgtm with nits.

https://codereview.chromium.org/2426893003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/audioparam-setTarget-timeConstant-0.html
(right):

https://codereview.chromium.org/2426893003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/audioparam-setTarget-timeConstant-0.html:19:
// |value| is the target value.  Non-integral values for |frame| tests
intergral - typo?

https://codereview.chromium.org/2426893003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/audioparam-setTarget-timeConstant-0.html:43:
gain: 1
Do we need this? It's by default 1.

https://codereview.chromium.org/2426893003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (right):

https://codereview.chromium.org/2426893003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:167: // The
time line code does not expect a timeConstant of 0. (IT
typo: "(IT" -> "It"

[hongchan, 2016-10-31 21:19:37]

Although the CL got l-g-t-m, we decided to push this CL with other dependent
changes (removing dezippering and etc).

From M57, we'll be showing the deprecation message for dezippering.

[Raymond Toy, 2016-12-05 22:00:21]

On 2016/10/31 21:19:37, hongchan wrote:
> Although the CL got l-g-t-m, we decided to push this CL with other dependent
> changes (removing dezippering and etc).
> 
> From M57, we'll be showing the deprecation message for dezippering.

Neither of us can remember why we made this decision and we can't remember 
how this is related to deprecation of dezippering.

So, I'm going to land this.  The spec now explicitly says 0 is allowed.

[Raymond Toy, 2016-12-05 22:00:33]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:01:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 22:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:38:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2016-12-09 17:01:23]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-12-09 17:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:00:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481302883738690, "parent_rev":
"4469418fb5dfa17671a6aad4ee5224c0156cbbd0", "commit_rev":
"4cbb702c02971a12b5a8156e414664c641352970"}

[commit-bot: I haz the power, 2016-12-09 20:01:09]

Description was changed from

==========
Allow timeConstant=0 for setTargetAtTime

setTargetAtTime should allow a time constant of 0.  This means the
output value jumps instantaneously to the target value at the start
time.

Spec:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-Aud...

BUG=630869
TEST=audioparam-setTarget-timeConstant-0.html,
     audiparam-exceptional-values.html

Remove test for timeConstant=0.
==========

to

==========
Allow timeConstant=0 for setTargetAtTime

setTargetAtTime should allow a time constant of 0.  This means the
output value jumps instantaneously to the target value at the start
time.

Spec:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-Aud...

BUG=630869
TEST=audioparam-setTarget-timeConstant-0.html,
     audiparam-exceptional-values.html

Remove test for timeConstant=0.

Review-Url: https://codereview.chromium.org/2426893003
==========

[commit-bot: I haz the power, 2016-12-09 20:01:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 14:37:06]

Description was changed from

==========
Allow timeConstant=0 for setTargetAtTime

setTargetAtTime should allow a time constant of 0.  This means the
output value jumps instantaneously to the target value at the start
time.

Spec:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-Aud...

BUG=630869
TEST=audioparam-setTarget-timeConstant-0.html,
     audiparam-exceptional-values.html

Remove test for timeConstant=0.

Review-Url: https://codereview.chromium.org/2426893003
==========

to

==========
Allow timeConstant=0 for setTargetAtTime

setTargetAtTime should allow a time constant of 0.  This means the
output value jumps instantaneously to the target value at the start
time.

Spec:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-setTargetAtTime-Aud...

BUG=630869
TEST=audioparam-setTarget-timeConstant-0.html,
     audiparam-exceptional-values.html

Remove test for timeConstant=0.

Committed: https://crrev.com/9f2135a54d2c7d6112f426a4a988e16a1c4ca9f2
Cr-Commit-Position: refs/heads/master@{#437614}
==========

[commit-bot: I haz the power, 2016-12-12 14:37:06]

Patchset 1 (id:??) landed as
https://crrev.com/9f2135a54d2c7d6112f426a4a988e16a1c4ca9f2
Cr-Commit-Position: refs/heads/master@{#437614}