MD Settings: Migrate certificate entry action menu to settings-action-menu.

MD Settings: Migrate certificate entry action menu to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1f76b9be0ec0b834610d3363b85664501c952c1
Cr-Commit-Position: refs/heads/master@{#425862}

[dpapad, 2016-10-17 20:53:58]

Description was changed from

==========
MD Settings: Migrate certificate entry action menu to settings-action-menu.

BUG=639718
==========

to

==========
MD Settings: Migrate certificate entry action menu to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-17 20:54:16]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 20:54:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-17 21:04:27]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:34:52]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-10-17 22:58:50]

lgtm

https://codereview.chromium.org/2426743002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2426743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/compiled_resources2.gyp:44:
'dependencies': [
lazy render?

[dpapad, 2016-10-17 23:06:18]

https://codereview.chromium.org/2426743002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2426743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/compiled_resources2.gyp:44:
'dependencies': [
On 2016/10/17 at 22:58:50, Dan Beam wrote:
> lazy render?

Done, although as revealed by the green closure compilation bot, the compiler
does not complain, because of its known lenient policy.

this.$.menu.get();
// Compiler's brain: I see at least one type having a get() method, so |menu|
might be of this type. Next....

I could cast to a CrLazyRenderElement first to make this a bit more obvious, but
then I would have two back to back type casts and an intermediate var, not sure
if it is better.

[dpapad, 2016-10-17 23:19:47]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-17 23:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2426743002/#ps20001
(title: "Nit.")

[commit-bot: I haz the power, 2016-10-17 23:20:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 02:33:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 02:33:20]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-18 02:33:41]

Description was changed from

==========
MD Settings: Migrate certificate entry action menu to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Migrate certificate entry action menu to settings-action-menu.

BUG=639718
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1f76b9be0ec0b834610d3363b85664501c952c1
Cr-Commit-Position: refs/heads/master@{#425862}
==========

[commit-bot: I haz the power, 2016-10-18 02:33:41]

Patchset 2 (id:??) landed as
https://crrev.com/d1f76b9be0ec0b834610d3363b85664501c952c1
Cr-Commit-Position: refs/heads/master@{#425862}