Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3011)

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html

Issue 2426743002: MD Settings: Migrate certificate entry action menu to settings-action-menu. (Closed)
Patch Set: Nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html b/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
index 8325fb23c05ce4a9685af2cfce543edef7d2e124..c4d559f1833d54cd6334a1825656f046e2b66309 100644
--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
@@ -1,21 +1,15 @@
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_render.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="/certificate_manager_page/certificate_manager_types.html">
<link rel="import" href="/certificate_manager_page/certificates_browser_proxy.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="settings-certificate-subentry">
<template>
<style include="settings-shared">
- .dropdown-content {
- background: white;
- /* TODO(dpapad): Use a CSS variable for box-shadow and unify with other
- * such menus (like in search engines section) */
- box-shadow: 0 2px 6px grey;
- }
-
.name {
flex: auto;
}
@@ -36,33 +30,29 @@
$i18n{certificateManagerUntrusted}
</div>
<div class="name">[[model.name]]</div>
- <paper-icon-button id="dots" icon="cr:more-vert" toggles
- active="{{menuOpened}}"></paper-icon-button>
- <!-- TODO(dpapad): Figure out RTL for this menu -->
- <template is="dom-if" if="[[menuOpened]]">
- <iron-dropdown vertical-align="auto" horizontal-align="right"
- opened="{{menuOpened}}">
- <div class="dropdown-content">
- <button class="dropdown-item" role="option" id="view"
- on-tap="onViewTap_">
- $i18n{certificateManagerView}
- </button>
- <button class="dropdown-item" role="option" id="edit"
- hidden$="[[!canEdit_(certificateType, model)]]"
- on-tap="onEditTap_">
- $i18n{certificateManagerEdit}
- </button>
- <button class="dropdown-item" role="option" id="export"
- hidden$="[[!canExport_(certificateType, model)]]"
- on-tap="onExportTap_">
- $i18n{certificateManagerExport}
- </button>
- <button class="dropdown-item" role="option" id="delete"
- hidden$="[[!canDelete_(model)]]" on-tap="onDeleteTap_">
- $i18n{certificateManagerDelete}
- </button>
- </div>
- </iron-dropdown>
+ <paper-icon-button id="dots" icon="cr:more-vert"
+ on-tap="onDotsTap_"></paper-icon-button>
+ <template is="cr-lazy-render" id="menu">
+ <dialog is="settings-action-menu">
+ <button class="dropdown-item" role="option" id="view"
+ on-tap="onViewTap_">
+ $i18n{certificateManagerView}
+ </button>
+ <button class="dropdown-item" role="option" id="edit"
+ hidden$="[[!canEdit_(certificateType, model)]]"
+ on-tap="onEditTap_">
+ $i18n{certificateManagerEdit}
+ </button>
+ <button class="dropdown-item" role="option" id="export"
+ hidden$="[[!canExport_(certificateType, model)]]"
+ on-tap="onExportTap_">
+ $i18n{certificateManagerExport}
+ </button>
+ <button class="dropdown-item" role="option" id="delete"
+ hidden$="[[!canDelete_(model)]]" on-tap="onDeleteTap_">
+ $i18n{certificateManagerDelete}
+ </button>
+ </dialog>
</template>
<div>
</template>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698