Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2426673003: Revert of Bump Chrome's deployment target to macOS 10.8. (Closed)

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bump Chrome's deployment target to macOS 10.8. (patchset #2 id:20001 of https://codereview.chromium.org/2420233002/ ) Reason for revert: This CL seems to break a number of layout tests on Mac bots. Most of them probably just needs an expectation update. The error logs are available here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/38229 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/38229/layout-test-results/results.html Original issue's description: > Bump Chrome's deployment target to macOS 10.8. > > I also updated the comment to better reflect the relationship between Chrome and > its dependencies. Several Chrome dependencies require a different min sdk and/or > deployment target from Chrome. > > BUG=622481 > > Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 > Cr-Commit-Position: refs/heads/master@{#425870} TBR=thakis@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622481 Committed: https://crrev.com/cf9dfba3347024cf81c6d46415f4f60ecedb8398 Cr-Commit-Position: refs/heads/master@{#425910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build_overrides/build.gni View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tzik
Created Revert of Bump Chrome's deployment target to macOS 10.8.
4 years, 2 months ago (2016-10-18 06:17:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426673003/1
4 years, 2 months ago (2016-10-18 06:17:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 06:18:14 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 06:20:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf9dfba3347024cf81c6d46415f4f60ecedb8398
Cr-Commit-Position: refs/heads/master@{#425910}

Powered by Google App Engine
This is Rietveld 408576698