Issue 2426673002: Rename CFX_CountRef to CFX_SharedCopyOnWrite

Issue 2426673002: Rename CFX_CountRef to CFX_SharedCopyOnWrite (Closed)

Created:
4 years, 2 months ago by Tom Sepez

Modified:
4 years, 2 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Rename CFX_CountRef to CFX_SharedCopyOnWrite Avoid confusing this class with other ref-counted objects. Committed: https://pdfium.googlesource.com/pdfium/+/2239cee23e914b974b458699d52733d7dd3116a6

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -252 lines)			Patch
M	BUILD.gn	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/page/cpdf_clippath.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/page/cpdf_colorstate.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/page/cpdf_contentmark.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/page/cpdf_generalstate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/page/cpdf_path.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/page/cpdf_textstate.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fxcrt/cfx_count_ref.h	View	1	1 chunk	+0 lines, -81 lines	0 comments	Download
M	core/fxcrt/cfx_count_ref_unittest.cpp	View	1	1 chunk	+0 lines, -129 lines	0 comments	Download
A +	core/fxcrt/cfx_shared_copy_on_write.h	View	1	5 chunks	+13 lines, -10 lines	0 comments	Download
A +	core/fxcrt/cfx_shared_copy_on_write_unittest.cpp	View	1	6 chunks	+15 lines, -15 lines	0 comments	Download
M	core/fxge/cfx_graphstate.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fxge/fx_dib.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 16 (10 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426673002/1

4 years, 2 months ago (2016-10-17 17:30:32 UTC) #5

Tom Sepez

On 2016/10/17 17:30:32, commit-bot: I haz the power wrote: > CQ is trying da patch. ...

4 years, 2 months ago (2016-10-17 17:41:24 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426673002/20001

4 years, 2 months ago (2016-10-17 18:15:47 UTC) #14

commit-bot: I haz the power

4 years, 2 months ago (2016-10-17 18:20:05 UTC) #16

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/2239cee23e914b974b458699d52733d7dd31...