Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: core/fxcrt/cfx_shared_copy_on_write.h

Issue 2426673002: Rename CFX_CountRef to CFX_SharedCopyOnWrite (Closed)
Patch Set: fix filenames Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/cfx_count_ref_unittest.cpp ('k') | core/fxcrt/cfx_shared_copy_on_write_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/cfx_shared_copy_on_write.h
diff --git a/core/fxcrt/cfx_count_ref.h b/core/fxcrt/cfx_shared_copy_on_write.h
similarity index 78%
rename from core/fxcrt/cfx_count_ref.h
rename to core/fxcrt/cfx_shared_copy_on_write.h
index 3b9ccff8fed1f8bfa3f2be032517fd206e247cc0..cd6cf6adc53f0e28bc5cdadc8c74e9a7bffcd66f 100644
--- a/core/fxcrt/cfx_count_ref.h
+++ b/core/fxcrt/cfx_shared_copy_on_write.h
@@ -4,8 +4,8 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef CORE_FXCRT_CFX_COUNT_REF_H_
-#define CORE_FXCRT_CFX_COUNT_REF_H_
+#ifndef CORE_FXCRT_CFX_SHARED_COPY_ON_WRITE_H_
+#define CORE_FXCRT_CFX_SHARED_COPY_ON_WRITE_H_
#include "core/fxcrt/cfx_retain_ptr.h"
#include "core/fxcrt/fx_system.h"
@@ -13,11 +13,12 @@
// A shared object with Copy on Write semantics that makes it appear as
// if each one were independent.
template <class ObjClass>
-class CFX_CountRef {
+class CFX_SharedCopyOnWrite {
public:
- CFX_CountRef() {}
- CFX_CountRef(const CFX_CountRef& other) : m_pObject(other.m_pObject) {}
- ~CFX_CountRef() {}
+ CFX_SharedCopyOnWrite() {}
+ CFX_SharedCopyOnWrite(const CFX_SharedCopyOnWrite& other)
+ : m_pObject(other.m_pObject) {}
+ ~CFX_SharedCopyOnWrite() {}
template <typename... Args>
ObjClass* Emplace(Args... params) {
@@ -25,7 +26,7 @@ class CFX_CountRef {
return m_pObject.Get();
}
- CFX_CountRef& operator=(const CFX_CountRef& that) {
+ CFX_SharedCopyOnWrite& operator=(const CFX_SharedCopyOnWrite& that) {
if (*this != that)
m_pObject = that.m_pObject;
return *this;
@@ -43,10 +44,12 @@ class CFX_CountRef {
return m_pObject.Get();
}
- bool operator==(const CFX_CountRef& that) const {
+ bool operator==(const CFX_SharedCopyOnWrite& that) const {
return m_pObject == that.m_pObject;
}
- bool operator!=(const CFX_CountRef& that) const { return !(*this == that); }
+ bool operator!=(const CFX_SharedCopyOnWrite& that) const {
+ return !(*this == that);
+ }
explicit operator bool() const { return !!m_pObject; }
private:
@@ -78,4 +81,4 @@ class CFX_CountRef {
CFX_RetainPtr<CountedObj> m_pObject;
};
-#endif // CORE_FXCRT_CFX_COUNT_REF_H_
+#endif // CORE_FXCRT_CFX_SHARED_COPY_ON_WRITE_H_
« no previous file with comments | « core/fxcrt/cfx_count_ref_unittest.cpp ('k') | core/fxcrt/cfx_shared_copy_on_write_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698