Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2426583002: libyuv: Switch {client,tryserver}.libyuv to GN (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: Switch {client,tryserver}.libyuv to GN For the masters; rename all the GN-based bots to GYP since the default is now switched to GN in https://codereview.chromium.org/2412033002/ Fix two bugs in the libyuv recipe that surfaced. BUG=chromium:652188 TBR=ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/3d9ee695a52c6ea7c00b60ae7ce8de03bbf626ed

Patch Set 1 #

Patch Set 2 : Fix recipe errors #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M masters/master.client.libyuv/master_android_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.client.libyuv/master_linux_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.client.libyuv/master_mac_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.client.libyuv/master_win_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.client.libyuv/slaves.cfg View 4 chunks +8 lines, -8 lines 0 comments Download
M masters/master.tryserver.libyuv/master.cfg View 3 chunks +8 lines, -8 lines 0 comments Download
M masters/master.tryserver.libyuv/slaves.cfg View 4 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/libyuv/api.py View 1 1 chunk +1 line, -1 line 1 comment Download
M scripts/slave/recipe_modules/libyuv/chromium_config.py View 1 1 chunk +1 line, -1 line 1 comment Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x_.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_release__nexus_5x_.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm64_debug__nexus_5x_.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_chromium
TBRing since current build is broken https://codereview.chromium.org/2426583002/diff/20001/scripts/slave/recipe_modules/libyuv/api.py File scripts/slave/recipe_modules/libyuv/api.py (left): https://codereview.chromium.org/2426583002/diff/20001/scripts/slave/recipe_modules/libyuv/api.py#oldcode124 scripts/slave/recipe_modules/libyuv/api.py:124: self.m.chromium_android.run_test_suite('yuv_unittest') The Android ...
4 years, 2 months ago (2016-10-17 11:20:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426583002/20001
4 years, 2 months ago (2016-10-17 11:20:51 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 11:30:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/3d9ee695a52c6ea7c00b...

Powered by Google App Engine
This is Rietveld 408576698