Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/libyuv/chromium_config.py

Issue 2426583002: libyuv: Switch {client,tryserver}.libyuv to GN (Closed)
Patch Set: Fix recipe errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/libyuv/api.py ('K') | « scripts/slave/recipe_modules/libyuv/api.py ('k') | scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/libyuv/chromium_config.py
diff --git a/scripts/slave/recipe_modules/libyuv/chromium_config.py b/scripts/slave/recipe_modules/libyuv/chromium_config.py
index 0b9a85b39e609eb581c66cd8246e7bc66d15bcf0..69e330258e3d89919e23779eee7c87698ba4eaee 100644
--- a/scripts/slave/recipe_modules/libyuv/chromium_config.py
+++ b/scripts/slave/recipe_modules/libyuv/chromium_config.py
@@ -52,7 +52,7 @@ def libyuv_ios(c):
if c.TARGET_BITS == 64:
gyp_defs['target_subarch'] = 'arm64'
- c.gn_args.append('target_os=%s' % c.TARGET_PLATFORM)
kjellander_chromium 2016/10/17 11:20:35 This needed the quoting.
+ c.gn_args.append('target_os="%s"' % c.TARGET_PLATFORM)
_libyuv_common(c)
_libyuv_static_build(c)
« scripts/slave/recipe_modules/libyuv/api.py ('K') | « scripts/slave/recipe_modules/libyuv/api.py ('k') | scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_tester_arm32_debug__nexus_5x_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698