Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2426573003: Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://coderev… (Closed)

Created:
4 years, 2 months ago by enne (OOO)
Modified:
4 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Causing shutdown crashes and can't find repro yet. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 Review-Url: https://codereview.chromium.org/2340083002 Cr-Commit-Position: refs/heads/master@{#425767} (cherry picked from commit 7c5d5c0654053d852ded6de612e7debc4073358a) Committed: https://chromium.googlesource.com/chromium/src/+/205e226a491bf7d0e0fd4fad04bf0b051538ab65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
enne (OOO)
4 years, 2 months ago (2016-10-17 20:50:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
205e226a491bf7d0e0fd4fad04bf0b051538ab65.

Powered by Google App Engine
This is Rietveld 408576698