Chromium Code Reviews
DescriptionRevert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ )
Reason for revert:
Causing shutdown crashes and can't find repro yet.
Original issue's description:
> Turn ~GpuProcessTransportFactory DCHECK into a CHECK
>
> If this DCHECK fails it means that some ui::Compositor has not been
> destroyed and unregistered itself. This is potentially really bad
> as ui::Compositor assumes that its context factory outlives it.
>
> This is to try to track down why this could be happening by
> making it a larger failure than it has been in the past.
>
> BUG=645075
>
> Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56
> Cr-Commit-Position: refs/heads/master@{#418003}
TBR=danakj@chromium.org
BUG=645075
Review-Url: https://codereview.chromium.org/2340083002
Cr-Commit-Position: refs/heads/master@{#425767}
(cherry picked from commit 7c5d5c0654053d852ded6de612e7debc4073358a)
Committed: https://chromium.googlesource.com/chromium/src/+/205e226a491bf7d0e0fd4fad04bf0b051538ab65
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||