Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2340083002:
Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (Closed)
|
Created:
4 years, 3 months ago by enne (OOO) Modified:
4 years, 2 months ago Reviewers:
danakj CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ )
Reason for revert:
Causing shutdown crashes and can't find repro yet.
Original issue's description:
> Turn ~GpuProcessTransportFactory DCHECK into a CHECK
>
> If this DCHECK fails it means that some ui::Compositor has not been
> destroyed and unregistered itself. This is potentially really bad
> as ui::Compositor assumes that its context factory outlives it.
>
> This is to try to track down why this could be happening by
> making it a larger failure than it has been in the past.
>
> BUG=645075
>
> Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56
> Cr-Commit-Position: refs/heads/master@{#418003}
TBR=danakj@chromium.org
BUG=645075
Committed: https://crrev.com/7c5d5c0654053d852ded6de612e7debc4073358a
Cr-Commit-Position: refs/heads/master@{#425767}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by enne@chromium.org
Created Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by enne@chromium.org
Description was changed from ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Found a local repro for where this is happening. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645075 ========== to ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Found a local repro for where this is happening. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} R=danakj@chromium.org BUG=645075 ==========
The CQ bit was checked by enne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Found a local repro for where this is happening. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} R=danakj@chromium.org BUG=645075 ========== to ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Found a local repro for where this is happening. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 ==========
danakj seems busy today and I want to get this into m55. She said I could just tbr this, so doing so.
The CQ bit was checked by enne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Found a local repro for where this is happening. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 ========== to ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Causing shutdown crashes and can't find repro yet. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Causing shutdown crashes and can't find repro yet. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 ========== to ========== Revert of Turn ~GpuProcessTransportFactory DCHECK into a CHECK (patchset #1 id:1 of https://codereview.chromium.org/2323303003/ ) Reason for revert: Causing shutdown crashes and can't find repro yet. Original issue's description: > Turn ~GpuProcessTransportFactory DCHECK into a CHECK > > If this DCHECK fails it means that some ui::Compositor has not been > destroyed and unregistered itself. This is potentially really bad > as ui::Compositor assumes that its context factory outlives it. > > This is to try to track down why this could be happening by > making it a larger failure than it has been in the past. > > BUG=645075 > > Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56 > Cr-Commit-Position: refs/heads/master@{#418003} TBR=danakj@chromium.org BUG=645075 Committed: https://crrev.com/7c5d5c0654053d852ded6de612e7debc4073358a Cr-Commit-Position: refs/heads/master@{#425767} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7c5d5c0654053d852ded6de612e7debc4073358a Cr-Commit-Position: refs/heads/master@{#425767} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
